Add pre-allocation to EscapeMetricFamily#828
Open
boekkooi-impossiblecloud wants to merge 2 commits intoprometheus:mainfrom
Open
Add pre-allocation to EscapeMetricFamily#828boekkooi-impossiblecloud wants to merge 2 commits intoprometheus:mainfrom
boekkooi-impossiblecloud wants to merge 2 commits intoprometheus:mainfrom
Conversation
boekkooi-impossiblecloud
force-pushed
the
pre-allocate
branch
from
8c1f9c2 to
18c2da5
Compare
Signed-off-by: warnar boekkooi <wboekkooi@impossiblecloud.com>
Signed-off-by: warnar boekkooi <wboekkooi@impossiblecloud.com>
boekkooi-impossiblecloud
force-pushed
the
pre-allocate
branch
from
18c2da5 to
e1f4bae
Compare
Author
|
Hello @roidelapluie, @gotjosh, @ArthurSens, Would one of you maybe have time to review this PR? Thanks in advance and have a great day! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
While I was checking some profiles I noticed that
EscapeNameandEscapeMetricFamilywhere doing a lot of allocation.This PR reduce this a little by pre-allocating the
MetricandLabelslices and the string builder for theUnderscoreEscapingstrategy inEscapeName.Thanks for reviewing and let me know what you think.
Have a good one!